Pjob/poc/pyapp binary with plugins #2035
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pjob
changed the base branch from
main
to
pjob/SNOW-1747473-enable-disable-plugin-commands
sfc-gh-pjob
commented
Jan 31, 2025
| @@ -14,4 +14,4 @@ | |||
|
|
|||
| from __future__ import annotations | |||
|
|
|||
| VERSION = "3.4.0.dev0" | |||
| VERSION = "3.4.0.dev8" | |||
There was a problem hiding this comment.
I have issues with caching of my builds, that's why I bump version in my PoC. This should be resolved.
| pip install -U hatch | ||
| hatch clean | ||
| hatch build | ||
| pip install git+https://github.com/hobbsd/[email protected] |
There was a problem hiding this comment.
- It's external script. It should be reviewed.
- The script uses tomllib, so it requires python 3.11.
| @@ -188,3 +188,6 @@ markers = [ | |||
|
|
|||
| [tool.codespell] | |||
| skip = 'tests/*,snow.spec' | |||
|
|
|||
| [tool.hatch.build.targets.binary] | |||
| python-version = "3.11" | |||
There was a problem hiding this comment.
I use python 3.11 but we had issues with pyinstaller binaries when using python 3.11 - we should check it.
| from dataclasses import dataclass | ||
|
|
||
| from snowflake.cli.api.plugins.command import CommandSpec | ||
|
|
||
| sys.path.append("/tmp/cli_plugins/lib/python3.11/site-packages") |
There was a problem hiding this comment.
We should consider if we can do it better. For sure we need to load plugins from configurable directory.
| ) -> CommandResult: | ||
| """Installs a plugin from a package""" | ||
| target_dir: str = ( | ||
| "/tmp/cli_plugins" # TODO make it configurable in config.toml with some default |
There was a problem hiding this comment.
It should be configurable.
There was a problem hiding this comment.
- This script is just PoC - probably not all commands are needed.
- I don't know how it works on different operating systems and CPUs.
- I don't how will work signing of the binaries.
- We should probably move the script to
scriptsdirectory.
| "-m", | ||
| "pip", | ||
| "install", | ||
| "--prefix", |
There was a problem hiding this comment.
--prefix, not --target to install only the plugin and new dependencies, without installation of existing CLI's dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
PoC: PyApp + plugins installed and loaded to/from custom directory