SNOW-715551: Support authentication with OKTA #799
Conversation
sfc-gh-ext-simba-jy
commented
Dec 17, 2024
•
sfc-gh-ext-simba-jy
commented
- Implemented Okta authentication.
- Unit testing for authentication was added.
- Manual testing for authentication was added.
Co-authored-by: sfc-gh-ext-simba-hx <[email protected]>
cpp/lib/Authenticator.cpp
Outdated
| m_retryTimeout = get_retry_timeout(m_connection); | ||
|
|
||
|
|
||
| //Todo: Need the server change. Currently testing with ODBC info. |
There was a problem hiding this comment.
@sfc-gh-mmishchenko will prepare PR to enable OKTA auth on the server side in version 2.0.0 of libsnowflakeclient
There was a problem hiding this comment.
I will remove this before I merge it or let me know if I can remove this.
There was a problem hiding this comment.
You cannot remove it now, we will need to remove it before releasing version 2.0.0 when the change on the server side is deployed
| @@ -0,0 +1,415 @@ | |||
| /** | |||
There was a problem hiding this comment.
let's add some comment why do we need to have this file here - also let's add a link to source (is it https://github.com/ooxi/entities/blob/master/entities.c) ?
do we need the whole file here? how is it related to the boost library we have in the project?
There was a problem hiding this comment.
maybe we should create an explicit dependency - @sfc-gh-ext-simba-hx @sfc-gh-jszczerbinski @sfc-gh-mmishchenko WDYT?
There was a problem hiding this comment.
I added the comment on the top.
The function we need is 'decode_html_entities_utf8'. This function calls parse_entity, which in turn calls both putc_utf8 and get_named_entity. The get_named_entity function then calls cmp. As a result, we need whole file.
