Ignore 405 error when S3 Acceleration is disabled on the S3 bucket #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-lb
changed the title
sfc-gh-ext-simba-lb
deleted the
ignore405ForGetBucketAccelerateConfiguration
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simba Salesforce ticket number 00406729.
Description provided by Snowflake Support:
When we need to upload a file to an internal stage using the PUT command it fails when GetBucketAccelerateConfiguration returns 405.
It happens when the driver tries to use the S3 acceleration service on the accounts where the S3 Acceleration is disabled on the buckets.
Observed behavior:
The driver fails with: ERRO[0000]connection.go:318 gosnowflake.(*snowflakeConn).queryContextInternal error: operation error S3: GetBucketAccelerateConfiguration, https response error StatusCode:
The file is not uploaded
In Snowflake job history the PUT query appears successful
Expected behavior:
The 405 error appears in the log
The file is uploaded
In Snowflake job history the PUT query appears successful
(This is how it is implemented in the python connector.)
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them