SNOW-1016278 Fix panic on empty arrow batches #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-1016278-panic-on-empty-arrow-batches
branch
from
1bbdf9c to
e1da080
Compare
sfc-gh-pfus
force-pushed
the
SNOW-1016278-panic-on-empty-arrow-batches
branch
from
e1da080 to
1b0b843
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 83.12% 83.16% +0.04%
==========================================
Files 50 50
Lines 9759 9759
==========================================
+ Hits 8112 8116 +4
+ Misses 1647 1643 -4 ☔ View full report in Codecov by Sentry. |
sfc-gh-dheyman
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1016278 Fixes getting arrow batches when query returns no results at all.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them