Generate right-length nodeIdentifier/ XID #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate right-length nodeIdentifier if nodeIdentifier is longer than 28 bytes, the XID generated by narayana ist too long, and it breaks. This shortens it, while nodeIdentifier remains unique. Fix ported from quarkus quarkusio/quarkus#30491
deepred-dev
changed the title
deepred-dev
changed the title
|
Imports look like they are not sorted. Can you fix that please? Thanks |
|
Hi,
yes of course.
But I am currently not in the office.
I hopefully can fix it by the end of this week.
Greetings Oliver
On 4. Mar 2024, at 07:27, Georgios Andrianakis ***@***.***> wrote:
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
Imports look like they are not sorted.
Can you fix that please?
Thanks
—
Reply to this email directly, view it on GitHub<#132 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQF3ZPVS56UH4TC5DIZC76TYWQH63AVCNFSM6AAAAABC333IFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVHAZDEOJVG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Thanks! |
|
Can you fix the checkstyle violation please ? |
Fix accidentally removed line
|
@geoand: Could you review again? |
|
Mind squashing and rebasing the commits please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate right-length nodeIdentifier
if nodeIdentifier is longer than 28 bytes, the XID generated by narayana ist too long, and and error occurs. This shortens the nodeIdentifier if necessary, while keeping it unique.
Fix ported from quarkus
quarkusio/quarkus#30491
quarkusio/quarkus@07b3a4c