Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check to know if the asset is checked out to the logged in user to allow check the state in the view #9847

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Jul 21, 2021

Description

Requested assets should not still allow a user to "cancel" request if it's been checked out to them. So I added a validation and if the asset is already deployed to the logged in user the button appears deactivated. Not sure if this is correct or if it's best to put a label indicating that 'the asset is already deployed to you (logged user)'. Please tell me if you think there's a better approach.

Fixes internal clubhouse [ch15357]

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

  • PHP version: 7.4.16
  • MySQL version: 5.7
  • Webserver version: nginx 1.21.1
  • OS version: Debian 10

Checklist:

@snipe snipe merged commit 798f6d6 into snipe:develop Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants