Develop v6 integration #9737
Merged
Develop v6 integration #9737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Javascript seems to build properly, and the routes can generate and it seems to kinda-sorta work?
The general direction I had to take here was literally the opposite of how I wanted to go. I was hoping to have all of the NPM packages all get appropriately
require()'ed as needed (orimport'ed if we wanted to be fancy). But too many of the libraries we use really want to just get<script src='ed instead from the<head>. So I ended up going the opposite direction - using concatenation more often than therequire()-style.Some vue changes were necessary due to some shifts in how Mix works.
routes/api.phpdid have a few minor typos, but I fixed those. Big changes to the latest routes format, and that was pretty painful.I'm sure that this isn't the end, it's still early on with this. But for us to make this go, we need to make the JS actually build properly and not throw errors on the dashboard. And this at least seems to do that?