Fix for #8076 #7945 and #5558 #8169
Conversation
app/Console/Commands/LdapSync.php
Outdated
|
|
||
|
|
||
| $permissions = config('permissions'); | ||
| $permissions_array = Helper::selectedPermissionsArray($permissions, Input::old('permissions', array())); |
There was a problem hiding this comment.
We should be using the old() helper here, instead of the Input:: facade.
Also where is this old data coming from? This is a console command, so there isn't any request data being passed.
There was a problem hiding this comment.
I have literally no knowledge of PHP, although i still understand what is happening in the code and what you mean. I just had this problem and i tried to fix it by looking up, how a user was normally created and from there it was just copy-paste with some testing until i found this to be working. But your totally right, that the old input is not needed. I even think, that the "use Input;" line is unnecessary then aswell.
|
Hey @Joly0 - after reading the code and the permissions array (and the It's creating a populated permissions array, with the default of no permissions active (which seems the safest approach), and then stores that on the Do you know if this could/should be reopened or merged to fix the issues you mention? |
As far as i can tell, this problem does no longer occur in v5 and higher, so opening a pr or reopening the old one wouldnt make any sense, as the codebase for v4 doesnt exist anymore. Though the fix is just a few lines of code most people should be able to implement. If there is any problem, i can write a short guide which files beed to be edited |
|
Thanks @Joly0! I think we should be OK without the patch and guide, in that case. |
Fixes #8076 , #7945 and #5558