Improve Audit Functionality #7580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only update location if asset is not checked out already.
Only update location on audit if asset is not already checked out.
Save checkout on audit setting when saving. Default value 0. The database needs the checkout_on_audit column added to the Settings table during install. I am unsure how.
Add Checkout on Audit option to general settings page
English lang reference, other languages would need translation.
Added check to checkout if asset is unassigned
Add check from settings to checkout on audit if item is checked out to location or is not checked out at all.
2 tasks
Added call to load settings
Fix for checking out of assets that are already checked out to audited location
Fix for checking out of assets that are already checked out to audited location
|
This functionality requires a new column in the Settings table called checkout_on_audit. I am unaware of how to accomplish this on install. |
Fix for can't save when require accept signature not checked. snipe#7437
Add routes for bulk checkin page
For issue snipe#6057
For issue snipe#6057
This does not work yet. For issue snipe#6057
Change button label to checkin
For issue snipe#6057
Add functionality for bulk checkin For issue snipe#6057
Removed functions that were placed in wrong file, moved to Assets/BulkAssetsController.php
Update Comment
2 tasks
|
@jacobsen9026 check out the failed checks above it might help speed up the integration of this feature. Unfortunately I am not capable of fixing the above issues |
|
Hey there! I’m so very sorry to have taken a hundred years to get this this, but I think this - mostly - looks okay. Can you handle the merge conflict maybe? I’m not exactly sure I understand the use case for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are my commits to improve the under construction update location checkbox and adding a setting to always checkout on audit if the asset is not assigned to a user already.