Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #6634: Asset Import History fixes and optimizations #6657

Merged
merged 8 commits into from
Feb 9, 2019
Merged

Fixed #6634: Asset Import History fixes and optimizations #6657

merged 8 commits into from
Feb 9, 2019

Conversation

herroworrd
Copy link
Contributor

I took a quick stab at fixing asset history imports.

Assumptions made:
-Asset history is coming from a previous management system.
-It isn't historical unless it has both a checkout and a checkin (sysadmin can fudge a checkin date if they don't have this information in previous system)
-The history importer no longer assigns assets (this can be done using the regular importer)

Optimizations made:
-Removed second iteration of asset import list, including all business attempting to 'magically' create past checkin dates
-Removed creation of, potentially giant, $items array
-Removed username matching schemes and only use that which is configured in settings
-CSV is sorted using league/csv statement filters (in post) on username to reduce db or cache calls
-Asset and User query results (both hits and misses) are cached (for 1 minute) to avoid duplicate queries
-Some better controls around date conversions included

@herroworrd herroworrd requested a review from snipe as a code owner January 29, 2019 17:52
@snipe snipe merged commit 3f7d2ae into snipe:develop Feb 9, 2019
@snipe
Copy link
Owner

snipe commented Feb 9, 2019

sealofapproval

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants