Fixing checking of user permissions when no user-specific permissions set #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user has no permissions set (=NULL) in the database (like after an LDAP import) but is a member of a group with permissions, those group permissions would not have be applied, effectively denying every access regardless of group permissions.
|
Thanks! I believe we fixed this on the creation side (possibly not with LDAP but at least with import) so that at least |
Sxderp
added a commit
to Sxderp/snipe-it
that referenced
this pull request
Feb 28, 2019
Fixes the null permission check for superuser permission. As well as reducing duplicated code by moving the checks to a separate function. This change has a slight backwards compatibility break. In the previous version a user could not be explicitly denied the superuser permission through user-specific config. If they were in a group with superuser they would always have superuser. Now the user-specific configuration will take precedence.
travismiller
added a commit
to tulsaschoolsdata/snipe-it
that referenced
this pull request
Oct 20, 2020
Fixed in v5.0.0 snipe#6229
snipe
pushed a commit
that referenced
this pull request
Apr 6, 2021
travismiller
added a commit
to tulsaschoolsdata/snipe-it
that referenced
this pull request
Jun 3, 2021
Fixed in v5.0.0 snipe#6229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has no permissions set (=NULL) in the database (like after an
LDAP import) but is a member of a group with permissions, those group
permissions would not have be applied, effectively denying every access
regardless of group permissions.