Feature/custom fields default values #5389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements changes suggested in #2608 (Models custom fields preloaded with data)
This branch:
get()
on result of relationship (CustomFieldsetController::fields()
), which I don't think can work? I can't find any other usage across the codebase, but have tested areas around custom fields for issues.To test:
Create a new model and assign an existing fieldset
Check the 'Add default fields' box
'Default values' box should appear below, enter some defaults
Save model
Create a new asset and set the model to the one created earlier
When custom fields appear they should be pre-filled
Edit an asset with some empty custom fields
Custom fields that were previously empty should still be empty
Custom fields tat were not empty should show their previous values
...only now realising it does not have ready for dev tag...oops! Will leave here anyway