Fix updates from v2

[dmeltzer]

Doing some investigation after #2058 popped up, it looks like the migration file 2013_11_22_213400_edits_to_settings_table.php differs between master and v3. In master it dropped option_name and option_value. In v3, this code is commented out (which explains the setup issues I saw when doing a fresh install, but not issues on a migrate). That means my PR last night was flawed.

This commit checks to ensure the column exists before dropping it. The other solution would be to uncomment the code in the migration, but that feels more unpredictable to me (It's still alpha though, so maybe easier).

This also breaks the migration up into two files because apparentlly with sqlite things behavior is undefined if dropping multiple columns in one migration.

[zmorrow]

Can you walk me through what I need to do, I uncommented those lines and still get the same error. Which table are those columns in?

[dmeltzer]

Hi,
The easiest way (without getting into too much git foo) would be to download the following two files:

https://raw.githubusercontent.com/dmeltzer/snipe-it/c52e3b5f9c8eadc01b54f3642b0dc9eca145ee0f/database/migrations/2016_05_20_024859_remove_option_keys_from_settings_table.php
and
https://raw.githubusercontent.com/dmeltzer/snipe-it/c52e3b5f9c8eadc01b54f3642b0dc9eca145ee0f/database/migrations/2016_05_20_143758_remove_option_value_from_settings_table.php

and put them in the snipe-it/database/migrations folder (The first one should overwrite the file that's currently there.

Then try running php artisan migrate once more and see if that fixes things.

Or wait until a bit later today and this or something similar will be available in the main git tree.

[zmorrow]

Getting the same error, strangely enough it didn't overwrite anything in that migrations folder though.

[dmeltzer]

What does ls snipe-it-directory/database/migrations/2016_05* show?

Also, if you are able to hop into the snipe-it gitter (https://gitter.im/snipe/snipe-it) it might be a little easy to take a look at this in real time.