Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dark background to fieldsets and right border #15784

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Nov 7, 2024

Description

Fixes the fieldset table background color and right border.

Before:
image

After:
image

These changes are applied to all dark themes.

Fixes #[sc-27326]

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner November 7, 2024 19:37
Copy link

what-the-diff bot commented Nov 7, 2024

PR Summary

  • Updated Styling Property
    The previous styling property border-left has been updated to a new property border-inline in the overrides.less file. This change enhances the flexibility of borders specification in our layout, allowing it to adapt better to different writing directions, hence improving the overall user interface experience.

  • Introduced New Style Rules
    A new set of style rules has been introduced for the class #sort tr.cansort across multiple skin files including skin-black-dark.less, skin-blue-dark.less, skin-green-dark.less, skin-orange-dark.less, skin-purple-dark.less, skin-red-dark.less, and skin-yellow-dark.less. These rules focus on specifying background-color and color parameters. This update intends to bring a more consistent and visually appealing experience to our users across all the different skins available.

@snipe snipe merged commit 0a87b0b into snipe:develop Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants