Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15548 - unify audit api endpoints #15549

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Sep 24, 2024

This removes some older code paths (since we changed the name of the urls slightly with a nicer version but still supported both). Now you can use /v1/hardware/audit/overdue or /v1/hardware/audits/overdue as the endpoint.

I don't love hanging on to legacy code, but this is necessary unless we want to do a full point release.

Should fix #15548.

Copy link

what-the-diff bot commented Sep 24, 2024

PR Summary

  • Asset Management Update
    Our asset management control tool has been updated to better handle older audit data sources by taking the 'audit' action and transforming it into 'audits'.

  • Improved Tracking
    To help us monitor changes and upcoming statuses in audits and check-ins, we've added more logging, which tracks each step of these processes.

  • API Route Modifications
    Changes to our API routes have been made to retire an older route used for audit data. The updated configuration now treats both 'audit' and 'audits' as valid actions. This will provide a seamless interaction for other services interacting with our API.

Signed-off-by: snipe <[email protected]>
@snipe snipe merged commit c38222e into develop Sep 24, 2024
9 checks passed
@snipe snipe deleted the fixes/#15548_unify_audit_api_endpoints branch September 24, 2024 17:10
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party but this looks good 👍🏾

@snipe
Copy link
Owner Author

snipe commented Sep 24, 2024

You weren't late, I was early :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants