-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring modals with partials and fixing misalignments #15498
Conversation
PR Summary
|
Modal fix p2
replace duplicate code with partials
Are those screenshots up to date? I'm not seeing the required indicators where I'd expect them to be, and I'd want those other select2 menus to reach all the way across to be even with the other text fields. |
Those were not the images you were looking for...all fixed! ✌️ |
Description
Cleaned up modals; refactored code into partials for reuse, cleaned up input alignment.
Screenshots of all modals that have more than one input:
Location Modal:
Status Modal:
Model Modal:
User Modal:
Fixes #[sc-26707]
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: