Fix - warn user on changing status to undeployable when editing #15492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer in the helpdesk and a few users in MacAdmins pointed out that we were not logging the checkin (or even the status change) if an asset is checked out and an admin changes the status to an undeployable status type. In the code, we were silently checking it in but we were NOT triggering a checkin event, and the edit didn't even show up in the history log:
Before
Snipe_Archived_Behaviour.mp4
After
Screen.Recording.2024-09-11.at.5.33.49.PM.mov
Big thanks for Dan Christovic and Guy for pointing out this bug.