Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to sort on qty and remaining for consumables #15463

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Sep 9, 2024

I'm always a little loathe to add anything raw as it can often times clash with non-mysql databases, but since mysql is the one we officially support, I guess this is worth doing for the functionality it brings.

Copy link

what-the-diff bot commented Sep 9, 2024

PR Summary

  • New functionality added to ConsumablesController.php
    A new feature was implemented into the 'ConsumablesController'. Specifically, this was designed to process a condition termed 'remaining' within the index function. Additionally, a new command to facilitate the ordering process, known as "OrderRemaining", was included in the "Consumable" model.

  • Change in Attributes of ConsumablePresenter.php
    We tweaked certain attributes within 'ConsumablePresenter.php'. For the columns named 'qty' and 'remaining', they were initially not sortable (as denoted by 'false'). Now, modifications have been made to enable sorting for these columns (changed to 'true').

@snipe snipe merged commit ce97e2a into develop Sep 9, 2024
8 of 9 checks passed
@snipe snipe deleted the consumables_order_by_remaining branch September 9, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant