Fixed: [sc-26355] Attempt to de-escalate SAML login and logout errors #15277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAML login and logout process are both pretty solid, but they do occasionally throw errors when there's some kind of misconfiguration. This ends up resulting in error 500 pages being returned to the user rather than a 4xx. Additionally, it adds a lot of 'noise' to our internal Rollbar tooling, and those errors aren't ones that we, ourselves can fix - only the customer can.
This change wraps the login and logout methods within a try/catch, and dumps a warning in the Laravel log (rather than an 'error').
Additionally, one of the SAML methods had an incorrect signature in its docblock that was making PHPStorm slightly annoyed, so I fixed that while I was there.
I was able to test the 'happy path' here and do a SAML login and logout on my local which worked OK.