-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed dashboard box overflow #15206
Fixed dashboard box overflow #15206
Conversation
PR Summary
|
I'm not seeing the ellipses here, only the word being cut off. Do we perhaps to need some additional padding in there so we're not smooshing it right up against the inner edge of the box? |
(Also, what's happening with that pie chart on the "after" pic? |
It also looks like it goofed with the alignment, where it's now center aligned instead of left aligned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes in the comments
@snipe so I fixed the box issue around the pie chart and recent activity and the text alignment, but I'm having issues making the ellipsis appear. i've applied |
Okay, no problem. I’ll take a look after our break tonight. |
Im wondering if it applies to missing letters of a word or only full words? Because its only two letters that get cut off 🤔 |
Description
This creates a class of
dashboard
that is applied to all the box menu options on the dashboard that deals with text overflow.Before:
After:
Fixes #15197
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: