Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dashboard box overflow #15206

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Aug 1, 2024

Description

This creates a class of dashboard that is applied to all the box menu options on the dashboard that deals with text overflow.
Before:
image

After:
image

Fixes #15197

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Aug 1, 2024

PR Summary

  • Improvement to Dashboard Display on Various Screen Sizes
    This change provides updates to the dashboard's appearance. It makes sure that nothing overflows or spills out of its designated area, and preserves proper text alignment. This ensures that the dashboard looks good and functions properly on all different sizes of screens. This enhances user experience significantly.

@snipe
Copy link
Owner

snipe commented Aug 2, 2024

I'm not seeing the ellipses here, only the word being cut off. Do we perhaps to need some additional padding in there so we're not smooshing it right up against the inner edge of the box?

@snipe
Copy link
Owner

snipe commented Aug 2, 2024

(Also, what's happening with that pie chart on the "after" pic?

@snipe snipe changed the title fixes dashboard box overflow Fixed dashboard box overflow Aug 13, 2024
@snipe
Copy link
Owner

snipe commented Aug 13, 2024

It also looks like it goofed with the alignment, where it's now center aligned instead of left aligned.

Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes in the comments

@Godmartinz
Copy link
Collaborator Author

@snipe so I fixed the box issue around the pie chart and recent activity and the text alignment, but I'm having issues making the ellipsis appear. i've applied display , a width, white-space: nowrap, and overflow with the text-overflow as recommended but I still get nothing 🤔

@snipe
Copy link
Owner

snipe commented Aug 13, 2024

Okay, no problem. I’ll take a look after our break tonight.

@Godmartinz
Copy link
Collaborator Author

Im wondering if it applies to missing letters of a word or only full words? Because its only two letters that get cut off 🤔

@snipe snipe merged commit f24031b into snipe:develop Aug 16, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants