Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookie serialization #15136

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Remove cookie serialization #15136

merged 3 commits into from
Jul 23, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 22, 2024

This is an attempt at removing the cookie serialization settings. We've tried this in the past and ended up breaking the API when testing, so this branch will need to be tested obviously.

Copy link

what-the-diff bot commented Jul 22, 2024

PR Summary

  • Cookie Encryption Changes

    • The encryption process for cookies has been updated. Specifically, we've updated the serialization setting which dictates how the data within the cookies is handled. In our case, we've switched the setting from true to false to adhere to best practices and enhance our application's security.
  • Changes In Authentication Service

    • We've made several updates to streamline our authentication service and ensure it aligns with the most recent version of the authentication library (Passport) we're using. These changes include:
      • Removing unnecessary function calls: Previous versions of Passport required a specific function call (Passport::routes()), however, with our upgrade, this is no longer necessary.
      • Modifying token expiration times: We've adjusted when each type of token (access tokens, refresh tokens, and personal access tokens) expires to ensure secure and efficient user authentication.
      • Deleting obsolete function: We've removed the Passport::withCookieSerialization() function call, as it is no longer essential with the latest Passport changes.

@snipe snipe requested a review from uberbrady July 22, 2024 13:22
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down this down and clicked through the dashboard, browsed the asset table, and created an asset (while also adding a new model) and didn't run into any issues. As expected I had to delete my session file to get the develop branch working again.

@snipe snipe merged commit 00ebc8b into develop Jul 23, 2024
9 checks passed
@snipe snipe deleted the fixes/cookie_serialization branch July 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants