Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #15121 - bulk delete restore logging #15122

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 19, 2024

This fixes #15121 where we were not properly logging bulk deleting and restoring of assets.

Copy link

what-the-diff bot commented Jul 19, 2024

PR Summary

  • Modification in the BulkAssetsController.php
    The BulkAssetsController.php file underwent modifications to improve how it performs and manages specific tasks. This change aims to boost overall performance and reliability.

  • Addition of withTrashed() method to the Asset model
    A new method called withTrashed() was introduced to the Asset model query. This addition allows us to interact more effectively with deleted entries, enhancing the flexibility and power of our data handling capability.

  • Replacement of $update_array logic with $asset->delete() method
    In a step to simplify and clarify our code, the logic previously performed by $update_array was replaced with the $asset->delete() method in the destroy function. This adjustment improves the readability and maintainability of our code.

@snipe snipe merged commit 9ea38fb into develop Jul 19, 2024
9 checks passed
@snipe snipe deleted the fixes/15121_bulk_delete_and_restore branch July 19, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant