Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15067 - updated ldap sync locale to use app()->getLocale() #15084

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 13, 2024

We were previously not setting a locale for imported/updated LDAP users, which would default them to en-US. This means that if the .env APP_LOCALE was set to something like de-DE, the user, on creation, would get created with en-US. This should fix this by using the app()->getLocale() value for the newly created user. This will NOT update existing users who are already synced with LDAP, as they may have already been manually updated and we won't want to override that.

Should fix #15067.

Copy link

what-the-diff bot commented Jul 13, 2024

PR Summary

  • Enhancement to Localization Features in LdapSync.php
    The existing localization synchronization process is improved with the addition of a new piece of code. This allows the system to effortlessly keep track of the set language preference.

  • Adjustment to Language Setting in CheckLocale.php
    The method to set the application language has been updated to a more standardized approach, improving the consistency and reliability of the language setting across the entire application.

  • Localization Update in Ldap.php
    The language preference is also now tracked within the Lightweight Directory Access Protocol (LDAP) process, which is a protocol for managing related information from a centralized location. This update will allow for a more tailored user experience.

  • User Creation Feature Update in Ldap.php
    During new user creation from LDAP, a user’s language preference is now included. This means users' preferred language is set from the start, making the application more user-friendly and ensuring a smooth onboarding experience.

@snipe snipe requested a review from uberbrady July 13, 2024 14:23
@snipe snipe changed the title Fixes #15067 - ldap sync locale Fixes #15067 - ldap sync locale to use app()->getLocale() Jul 13, 2024
Signed-off-by: snipe <[email protected]>
@snipe snipe changed the title Fixes #15067 - ldap sync locale to use app()->getLocale() Fixes #15067 - updated ldap sync locale to use app()->getLocale() Jul 13, 2024
@Godmartinz
Copy link
Collaborator

Works on my end. Users locales' were updated on sync. 👍

@snipe
Copy link
Owner Author

snipe commented Jul 17, 2024

Excellent, thanks @Godmartinz!

@snipe snipe merged commit 0ac82fb into develop Jul 17, 2024
9 checks passed
@snipe snipe deleted the fixes_ldap_sync_locale branch July 17, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants