Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes path for redirect response #14787

Merged
merged 1 commit into from
May 29, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented May 29, 2024

Super small fix that handles only the docblocks to normalize the redirect response @return

Copy link

what-the-diff bot commented May 29, 2024

PR Summary

  • Function Return Type Modifications
    This pull request primarily focuses on refining the function return types in multiple controller files within the codebase. Specifically, the return types of various functions were changed from Redirect to a more explicit \Illuminate\Http\RedirectResponse. As such, the code is now more intuitive and specific, which can potentially enhance the overall maintainability and code clarity.

    Here is a non-exhaustive list of some of the changed files:

    • Accessories, Asset Models, and Assets Controllers
    • Accessory Checkin, Checkout Controllers
    • Acceptance, API and Asset Checkin Controllers
    • Login, SAML, and Profile Controllers
    • Settings and View Assets Controllers
    • Several other files in the project.

    Note: The return type modification aids developers in catching issues during compile time, resulting in code that is safer and less prone to run-time errors. The benefits include but not limited to improving application performance, error management, and code readability.

@snipe snipe merged commit 037ee8c into develop May 29, 2024
8 checks passed
@snipe snipe deleted the fixes/return_redirect_fixes_for_docblock branch May 29, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant