Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a command to resend acceptance emails #14722

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This adds an artisan command option snipeit:acceptance-reminder to allow you to resend the acceptance email to all listed on the unaccepted assets report.
image

Fixes #11756 [sc-25560]

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented May 15, 2024

PR Summary

  • Introduction of a New Console Command
    A new file named SendAcceptanceReminder.php has been incorporated within the 'Console/Commands' directory. Its purpose is to automate the sending of reminders to users who have yet to accept allocated assets. This change should streamline the entire notification process while ensuring no user with pending assets gets overlooked.

Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requests, but this is a great start :)

} else {
Notification::send(
$unacceptedAsset['acceptance']->assignedTo,
new CheckoutAssetNotification($unacceptedAsset['assetItem'], $unacceptedAsset['acceptance']->assignedTo, $unacceptedAsset['assetItem']->adminuser, $unacceptedAsset['acceptance'], '')
Copy link
Owner

@snipe snipe May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you're doing here ;) And it's good! This could end up sending a shitload of emails to the same user since this is a new alert tho, and they could have 300 unaccepted things. I feel like a new blade with a rollup would make more product sense, and please also revisit the original issue to make sure that the user-reminder is the actual ask, versus admin notification and/or both.

@snipe
Copy link
Owner

snipe commented May 15, 2024

@Godmartinz three merits deducted for pushing code during a 1:1 ;)

@Godmartinz
Copy link
Collaborator Author

@Godmartinz three merits deducted for pushing code during a 1:1 ;)

😆 I lost track of time!

@Godmartinz
Copy link
Collaborator Author

@snipe few fixes added, going to tackle the new notification instance and then should be good to go 🤞

@Norjek
Copy link

Norjek commented Jun 6, 2024

Nice idea, looking forward to when this comes around :)

@snipe
Copy link
Owner

snipe commented Jun 12, 2024

@Godmartinz was this intended to be targeted to master btw?

@snipe
Copy link
Owner

snipe commented Jun 24, 2024

I think we may actually want to rethink this actually. If we do this right, we can solve several birds with one stone. We'll talk more about it in the dev meeting or on slack.

@Godmartinz Godmartinz changed the base branch from master to develop June 26, 2024 16:48
@Godmartinz
Copy link
Collaborator Author

@snipe as per the meeting, this was the PR you were referring to yes?

@snipe snipe merged commit 5697370 into snipe:develop Jul 11, 2024
10 of 12 checks passed
@snipe
Copy link
Owner

snipe commented Jul 11, 2024

I think this still could use some polish, but it's better than what we have... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Bulk Unaccepted Assets Reminder Mail
3 participants