Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load settings in SendUpcomingAuditReport command #14690

Merged
merged 2 commits into from
May 7, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR adds $settings = Setting::getSettings(); to the top of SendUpcomingAuditReport so audit_warning_days can be referenced properly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

what-the-diff bot commented May 6, 2024

PR Summary

  • Implementation of Settings Retrieval
    The PR includes updated code which allows us to fetch our application's settings and store them for further use.

  • Setting Audit Warning Duration
    From these settings, we extract and store the "audit_warning_days" value specifically. This represents a certain time period in days that we're particularly interested in.

  • Calculation of Future Date
    We take the current date and add the "audit_warning_days" value to it. This helps us predict a future date, referred to as "interval_date" in the code. This assists in determining when our next audit warning should be triggered.

@snipe snipe merged commit fd929f5 into snipe:develop May 7, 2024
8 checks passed
@marcusmoore marcusmoore deleted the import-settings-properly branch June 24, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants