Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the getExpiringLicenses query #13764

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

Fixed the query to check if there are any expiring licenses coming up.
image

Fixes #SC-23848

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Oct 18, 2023

PR Summary

  • Improved Efficiency in License Model
    The method used for fetching expiring licenses in your application has been streamlined to improve efficiency and speed. The unnecessary database raw function has been removed, simplifying the process.

@snipe
Copy link
Owner

snipe commented Nov 13, 2023

Was this meant to be targeted to v4?

@Godmartinz
Copy link
Collaborator Author

yes, i believe it only happens on v7. If Im recalling what brady said correctly.

@snipe snipe merged commit 1360103 into snipe:snipeit_v7_laravel10 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants