Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13592 - unable to delete model from view page #13606

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Sep 14, 2023

This is a refactor of #13603. @inietov can you pull this branch down and see if this works better?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23705: Unable to delete Asset Models from the asset model view.

@snipe snipe requested a review from inietov September 14, 2023 22:36
@what-the-diff
Copy link

what-the-diff bot commented Sep 14, 2023

PR Summary

  • New Translation Strings Introduced
    Two new translation strings, 'sure_to_delete_var' and 'delete_what', have been added in the general.php file. This change allows for more customizable user-facing messages.

  • User Interface Changes on Model View Page
    The view models/view.blade.php has been updated. Instead of a hyperlink for deleting a model, a button has been introduced to enhance visibility and accessibility. Furthermore, upon clicking this delete button, a modal window is displayed to the user, for a better, more intuitive user interaction.

Copy link
Collaborator

@inietov inietov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a step up against my take on this. Thanks.

@snipe snipe merged commit 8a8afef into develop Sep 15, 2023
@snipe snipe deleted the feature/sc-23705 branch September 15, 2023 00:11
@jayavman
Copy link

Hi all,

Just ran the update for this fix. Now it's brought on another issue (that was working before the update)

20230915171936653.mp4

and the issue is still happening

20230915172508178.mp4

I'm on v6.2.0-pre build 11391 (g319cb2305) I just updated from master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants