Fixed #13500 - Try to prevent the browser from pre-filling the LDAP password #13537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #13500, where the user's browser was pre-filling the
ldap_pword
field to be "helpful", which meant every time they saved the LDAP settings, theldap_pword
field would be overwritten in the database to their own user password. Thanks, browser! Super helpful.@Godmartinz - if this looks okay, can we try to apply this to your new LDAP livewire stuff? (We should also maybe add a new class to the CSS to make this part of our actual CSS, versus inlining it, as those in dark mode will have a white field that will look pretty jarring. A new class like
hide-readonly
or something.This PR yoinks a lot of the functionality from the user edit/create page for largely the same reasons - before adding that, admins who were editing a user wouldn't notice that the browser filled in that field with the admin's password:
snipe-it/resources/views/users/edit.blade.php
Lines 27 to 31 in b93adf4
snipe-it/resources/views/users/edit.blade.php
Lines 153 to 163 in b93adf4