Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13521 - make modal “select files” button wider #13535

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 28, 2023

While I don't think this visually looks as nice as the previous incarnation, a user brought up that for languages that have very long strings as the phrase for "select file" or "select files", the button text runs off the side of the button. This change makes the button the full width of the modal, and puts the selected files underneath.

Before

262925549-03b12e7e-8433-4ba4-9999-b83e9d8e230e

After

Screenshot 2023-08-28 at 12 36 41 PM

Fixes #13521

@snipe snipe merged commit 535ca0e into develop Aug 28, 2023
@what-the-diff
Copy link

what-the-diff bot commented Aug 28, 2023

PR Summary

  • User Interface Adjustment in upload-file.blade.php
    The user interface has been optimized to provide a more balanced and aesthetic design. This was achieved by modifying the width of certain sections to utilize the full available column width.

  • Enhancement of Label Element
    The label element has been updated to not only serve as a descriptive label but also as a clickable control for better user interaction.

  • Button Text Update
    The Upload Button has been updated to imply the ability to select multiple files at once, providing the users with a clearer interface and accurate instructions.

These changes serve to improve the user experience by making the interface more intuitive and user-friendly.

@snipe snipe deleted the fixes/13521_make_modal_upload_button_wider branch January 17, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant