Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13510 - do not use translations in migrations #13511

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 23, 2023

This should hopefully fix #13510. The original PR was trying to be very clever and use the translated strings for the default values, but unfortunately values with apostrophes (French, etc) would break the migration.

@snipe snipe merged commit d393bd5 into develop Aug 23, 2023
@snipe snipe deleted the fixes/13510_no_translations_in_migrations branch August 23, 2023 07:21
@what-the-diff
Copy link

what-the-diff bot commented Aug 23, 2023

PR Summary

  • Modification of Default Values in Label Settings
    The changes introduced in this pull request involve the update of default settings for certain labels. These settings are stored in a file named add_label2_settings.php located in our database migration folder. Here are the specifics:

    • The default configurations for the label types, specifically label2_1d_type and label2_2d_type, along with the label2_2d_target have been modified.

    • The default setup for label2_fields has been updated to 'name=name;serial=serial;model=model.name;'. This reflects the value fields used in the second type of label.

The updated settings will allow better management and customization of labels, improving the system's usability to match our user requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant