Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed checkboxes for accessibility #13469

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 15, 2023

For label UI. This makes the checkboxes on the same line as their label, and also makes them checkable/uncheckable via clicking on the label

@snipe snipe merged commit bc4a474 into develop Aug 15, 2023
@snipe snipe deleted the fixes/missed_one_checkbox_in_label branch August 15, 2023 19:30
@what-the-diff
Copy link

what-the-diff bot commented Aug 15, 2023

PR Summary

  • Improvement of Placeholder Notations
    A change was made in files app/View/Label.php and resources/lang/en/admin/settings/general.php where the placeholder :company was replaced with {COMPANY} in the label2_title_help_phold variable. This delivers a more consistent code and offers better readability.

  • Enhancement in Checkbox Functionality
    In the resources/views/settings/labels.blade.php file, the mechanics of the checkbox for label2_enable were improved. Now it checks if either old values or the current setting value is 1. This enhances the functionality of the checkbox by giving additional conditions under which it can be activated.

  • Interface Update for Checkbox
    Styling of the label2_asset_logo checkbox was shifted to utilize Bootstrap's checkbox formatting. The new styling via Bootstrap makes it visually more coherent with the rest of the user interface, enhancing the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant