Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded Company::scopeCompanyables from ReportsController #13431

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR simply removes Company::scopeCompanyables from the ReportsController since the Asset model already has the CompanyableTrait on it.

Another small step in the direction of simplifying how models are scoped to companies.

Type of change

  • Bug fix (non-breaking change which fixes an issue) (sort of)

@what-the-diff
Copy link

what-the-diff bot commented Aug 9, 2023

PR Summary

  • Updated Asset Selection in ReportsController
    Our ReportsController file has changed how it manages the selection of certain assets. This means the system might operate differently when gathering and presenting data for these assets.

  • Additional Permission Control in UserFactory
    Our UserFactory file now includes a 'canViewReports' method. This update directly affects how users' permissions are identified and allocated when it comes to viewing reports. In simpler words, it's a new rule to decide who can see what sorts of reports.

  • New Testing for Custom Reports
    We've introduced a new file named CustomReportTest. This file contains tests that specifically focus on generating custom asset reports. This is part of our ongoing efforts to make sure the new system for customized report generation is working as expected.

@snipe snipe merged commit 6adaa32 into snipe:develop Aug 10, 2023
@marcusmoore marcusmoore deleted the feature/custom-report-scoping branch August 10, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants