Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add button delete page view asset #13065

Closed
wants to merge 1 commit into from
Closed

feature: add button delete page view asset #13065

wants to merge 1 commit into from

Conversation

NojoudAlshehri
Copy link
Contributor

@NojoudAlshehri NojoudAlshehri commented May 22, 2023

Description

Feature: added delete asset button when user is in assets detail page

It will also ask for confirmation before deletion.

I added a button for delete asset, made a call to API for Delete And added a confirmation popup to confirm delete.

image

Fixes #12567

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test A: Go to any Asset, Click on actions and click Delete.
  • Test B: a Red Confirmation message will popup asking to confirm delete. Click Delete to delete the asset.

Test Configuration:

  • PHP version: PHP 8.0.28
  • MySQL version: 10.4.28-MariaDB
  • Webserver version: Apache/2.4.56
  • OS version: Windows 11

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented May 22, 2023

PR Summary

  • New Delete Asset Modal
    A new modal has been added to allow deleting individual assets.
  • Updated Asset Detail View
    The asset detail page now includes a delete option in the dropdown menu, but only for assets that are not deleted or assigned to someone else.

@snipe
Copy link
Owner

snipe commented May 23, 2023

This will be subsumed by #12940

@snipe snipe closed this May 23, 2023
@NojoudAlshehri
Copy link
Contributor Author

Hello @snipe ,
I think the code Here is more optimized than #12940 , or is there another proble?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Delete Button in Actions Dropdown on Assets
2 participants