Returning the hyphen to this pattern #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, looking closer I think it would have been more appropriate to just escape the dash at the beginning of the pattern so it's not interpreted as a range... How do I delete this thing ;-D |
Closed
Closed
2 tasks
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the hyphen was dropped in the last commit to this file. The result is that fields which should permit hyphens/dashes (like the License Serial Number) do not allow them, contrary to even the error message on the field.
I fixed it by adding the hyphen back to the pattern, I'm not sure if I'm doing this pull request correctly though, so please let me know if this is the wrong process.