Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #12027: Add memcached php extensions to docker images #12028

Conversation

StarlessNights
Copy link
Contributor

Description

Adds the missing php extensions to Ubuntu and Alpine docker images.

Fixes #12027

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Built new images with my changes included, and tried them with the official Memcached docker images.
The reported errors disappeared and all appears to work.

Checklist:

@StarlessNights StarlessNights requested a review from snipe as a code owner October 25, 2022 13:49
@welcome
Copy link

welcome bot commented Oct 25, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@StarlessNights StarlessNights changed the title Fixed #<12027>: Add memcached php extensions to docker images Fixed #12027: Add memcached php extensions to docker images Oct 25, 2022
@snipe snipe requested a review from uberbrady October 25, 2022 19:14
@snipe
Copy link
Owner

snipe commented Oct 25, 2022

Thanks for this!

@snipe snipe merged commit f54c92a into snipe:develop Oct 25, 2022
@welcome
Copy link

welcome bot commented Oct 25, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@StarlessNights
Copy link
Contributor Author

No problem!

There is yet the Dockerfile.fpm-alpine, which I didn't dare to touch. It may or may not have the same issue.

It's also a bit unclear what all of these dockerfiles are being used for.

@StarlessNights StarlessNights deleted the feature/add-memcached-php-extensions-to-docker-images branch November 1, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants