Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed kit checkout permissions if admin is not superadmin #11058

Merged
merged 2 commits into from
May 12, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented May 12, 2022

This is kind of a shit solution to a bigger problem. Kits have always had a problem since it was first introduced, and this does NOT solve that problem - it just puts it back to the back the way it was before (which was kinda broken.)

The real issue is that there should never have been a Kits:checkout permission. Kits are just a collection of things, so if you don't have permission to check out assets, you shouldn't be able to check out assets via kit.

Kits will be completely revamped after v6 launches on Friday, but this at least restores the previous functionality. A change we made recently removed the checkout button from kits if you were not a superadmin - which kinda makes sense, since a superadmin would have the ability to check out all of the things within a kit (assets, licenses, etc). You may still hit forbidden errors if you don't have asset checkout permission as a non-super admin, but that part was always true anyway. I suspect the majority of use cases here use assets as the primary thing that's being checked out.

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know that I fully understand this - I’ve put some questions in there.

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this seems good.

@snipe snipe merged commit 722e88a into master May 12, 2022
@snipe snipe deleted the fixes/kit_permissions branch May 12, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants