Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #10983: Possibility to set region for AWS (SES) #10982

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

chrisweirich
Copy link
Contributor

Description

Currently, you cannot set the AWS region for SES. A corresponding environment variable has been introduced for this - as in the Laravel standard.

@chrisweirich chrisweirich requested a review from snipe as a code owner April 27, 2022 13:30
@welcome
Copy link

welcome bot commented Apr 27, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@chrisweirich chrisweirich changed the title Possibility to set region for AWS (SES) Fixed #10983: Possibility to set region for AWS (SES) Apr 27, 2022
@chrisweirich
Copy link
Contributor Author

To use Amazon SES it is also needed to add a composer package:
composer require aws/aws-sdk-php

@snipe
Copy link
Owner

snipe commented Apr 28, 2022

We already use the AWS SDK because of Flysystem (composer.lock):

            "aws/aws-sdk-php": "^2.4.9 || ^3.0",

@snipe snipe merged commit c8d5445 into snipe:develop Apr 28, 2022
@welcome
Copy link

welcome bot commented Apr 28, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants