Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Customfields with boolean format not saving [ch-9973] #10809

Merged

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Mar 10, 2022

Description

I change the value of the CustomField with boolean format if gets as string instead of boolean type, because if a string with "true", "false", "1" or "0" values doesn't pass the boolean validation.

I also change the 'show' and 'edit' views for this format to look like a green check if true and a red 'x' if false.

Fixes clubhouse story 9973

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 7.4.16
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@inietov inietov marked this pull request as ready for review March 16, 2022 23:33
@snipe snipe merged commit 42220cc into snipe:develop Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants