Check if table exists before trying to create in migrations #10799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <[email protected]>
snipe
changed the title
uberbrady
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
I think this happens when customers set up a new server, then load up their old data onto the new server (without wiping the DB first). That means they have new schema with some old data. Fun times.
This fix looks GREAT - I'm sure it will help the next weird 'mangled' restore we have to do!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fringe case, and I'm still not 100% sure why it happens sometimes but not all the time, usually with customers who have given us a backup and they wish to migrate to hosted. Somehow the migration tables get mangled where they don't actually register a few of the migrations, so they keep trying to re-run them, which means the migrations never complete.
This change targets those specific files that seem to fail in these circumstances and checks to make sure the table doesn't already exist before trying to create it.
You're welcome, @uberbrady :)
Signed-off-by: snipe [email protected]