Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added trim to email and username #10776

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Added trim to email and username #10776

merged 2 commits into from
Mar 4, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Mar 4, 2022

This just sprinkles in a few additional trim() methods so that we don't end up with RFC violations/errors on Swiftmailer.

@snipe snipe requested a review from uberbrady March 4, 2022 14:21
uberbrady
uberbrady approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty reasonable to me. Fewer errors is better :)

I got a little confused around the removal of the e() function call. Generally I just get nervous when I see those things disappear, but I think this is correct in this case.

app/Http/Controllers/Users/UsersController.php Show resolved Hide resolved
@snipe snipe merged commit 2d7a8b5 into develop Mar 4, 2022
@snipe snipe deleted the added_trim_to_email_and_username branch March 4, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uberbrady uberbrady uberbrady approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snipe @uberbrady