Fixes #10627 Inconsistencies between checkout/checkin dates on asset history and activity log

[inietov]

Description

Some time ago I add custom checkin dates to the checkin assets form, and the world were a happier place. Until users figure out that I made a mistake :(.

This PR builds over #6733 and finish the implementation of custom checkins, all was more or less ok, but I forgot to actually add the checkin_at to the logger, so every checkin found that their action_date unpopulate, making that the Activity report show the date in which it was checked in, not the custom date the user set.

Also, in the history tab of every asset details, the Bootstrap Table was using the created_at column, instead of the action_date one.

Fixes #10627

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

• PHP version: 7.4.16
• MySQL version: 8.0.23
• Webserver version: nginx/1.19.8
• OS version: Debian 10

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[JonathonReinhart]

Until users figure out that I made a mistake :(.

Sorry!

Thanks @inietov and @snipe for rapidly addressing this! 🎉

I would argue that this is only a Bug fix and not a New feature. Thus, it qualifies to be cherry-picked into master, per this conversation with @snipe: #10629 (comment)

Once we have this in place, I can finish testing the addition of the checkin_at parameter to the /hardware/{id}/checkin API: #10552 (comment). Given how simple of a fix this is, I would love to see this in v5.3.9 also.

This would allow me to address some "bulk checkin" related things on my v5.x instances before we're ready to take the leap into v6.x (which by its nature is bound to have bugs).

[inietov]

Its cool! Im grateful it got detected because i introduce the bug when added the feature.

Thats why I marked it as new feature, because in reality it was an unfinished feature? But for sure its a small change since everything was already in place.

[inietov]

5.3.9 is master? If so, a PR is already submitted to master, which you can test before it gets merged if is not already. 😀

[JonathonReinhart]

5.3.9 is master?

Yes. master is currently just 9 merge commits ahead of the v5.3.8 tag. So I'm assuming @snipe will want to take master as v5.3.9 in a couple of weeks or so.

If so, a PR is already submitted to master, which you can test before it gets merged if is not already. grinning

Okay, cool. Are you talking about #10636? Yep it looks like it is already merged. Thanks.

I will test my fix for #10552 (comment) tonight.