Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace .my.cnf with column-statistics.cnf at the system level for mysqldump #10579

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

misilot
Copy link
Contributor

@misilot misilot commented Jan 29, 2022

Fixes #10176

Replace .my.cnf with column-statistics.cnf at the system level for mysqldump

The column-statistics.cnf file is copied to /etc/mysql/conf.d/column-statistics.cnf for each Dockerfile that exists.

This puts it as a system level mysql client change, so the web ui interface also works.

Description

Adds a mysql configuration file that disables column-statistics for mysqldump, which allows the snipe-it backup to run as expected. As well as the web ui for making backups, as pointed out by @aduzsardi

Fixes # 10176

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Try running backup from existing container, to a mysql 5.x database server. It fails. Add the column-statistics.cnf to /etc/mysql/conf.d/column-statistics.cnf with the following contents:

[mysqldump]
column-statistics=0

Run backup from web ui.

Checklist:

…sqldump

Fixes snipe#10176

The `column-statistics.cnf` file is copied to `/etc/mysql/conf.d/column-statistics.cnf` for each Dockerfile that exists.

This puts it as a system level mysql client change, so the web ui interface also works.
@snipe snipe merged commit a7d34df into snipe:develop Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants