Force UrlGenerator's Root URL to be the base of APP_URL unless overriden #10528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances attackers can forge a
Host:
header and phish users into visiting incorrect domains. Also adds a new.env
var that permits overriding this new restriction.This has not been fully tested yet. I don't have a subdirectory configuration working for Snipe-IT yet so I can't quite test that, but I'm pretty sure that the hostname part works, and the
.env
var is being correctly respected.Tests -
APP_URL
forces all generated URL's to follow theAPP_URL
APP_URL
at least doesn't double-up the subdirectory name (reported problem in the wild with this particular solution, which I fixed)APP_ALLOW_INSECURE_HOSTS
permits the old behaviorMarking this as [WIP] because not all tests are complete