-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding .my.cnf to disable column-statistics backup #10509
Conversation
Fixes snipe#10176 The ```.my.cnf``` file is copied to ```/root/.my.cnf``` for each Dockerfile that exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely love it! Thank you.
@snipe should we try and merge this not only to develop, but to 'master' as well? I don't like the idea that some of our Docker users can't really back up effectively. |
@uberbrady, do you want me to make a PR to |
Let's see what the boss says - but it's only one commit so I'm fine with cherrypicking. |
This seems fine - if you want to open a PR against master as well, I'll take it. |
(I am trying to get an RC out in the next day or so, so trying to limit changes as much as we can, but we already have a bunch of PRs to get through.) |
Awesome, thanks! |
Hi! |
Yes you could add this your existing running container. The easiest would probably to be to add it to your docker-compose.yml as a new volume mount point |
Fixes #10176
The
.my.cnf
file is copied to/root/.my.cnf
for eachDockerfile that exists
Description
Adds a mysql configuration file that disables column-statistics for mysqldump, which allows the snipe-it backup to run as expected.
Fixes # 10176
Type of change
How Has This Been Tested?
Try running backup from existing container, to a mysql 5.x database server. It fails. Add the
.my.cnf
to /root with the following contents:Run
docker-compose exec snipe-it sh -c 'php artisan snipeit:backup'
, backup succeeds.Checklist: