Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue when creating a status label via API - default_label and show_in_nav being not nullable #10103

Merged
merged 3 commits into from
Sep 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/StatuslabelsController.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function store(Request $request)
$statuslabel->archived = $statusType['archived'];
$statuslabel->color = $request->input('color');
$statuslabel->show_in_nav = $request->input('show_in_nav', 0);
$statuslabel->default_label = $request->input('default_label');
$statuslabel->default_label = $request->input('default_label', 0);


if ($statuslabel->save()) {
Expand Down Expand Up @@ -124,8 +124,8 @@ public function update(Request $request, $id)
$statuslabel->pending = $statusType['pending'];
$statuslabel->archived = $statusType['archived'];
$statuslabel->color = $request->input('color');
$statuslabel->show_in_nav = $request->input('show_in_nav');
$statuslabel->default_label = $request->input('default_label');
$statuslabel->show_in_nav = $request->input('show_in_nav', 0);
$statuslabel->default_label = $request->input('default_label', 0);

if ($statuslabel->save()) {
return response()->json(Helper::formatStandardApiResponse('success', $statuslabel, trans('admin/statuslabels/message.update.success')));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class AddShowInNavToStatusLabels extends Migration
public function up()
{
Schema::table('status_labels', function (Blueprint $table) {
$table->boolean('show_in_nav')->default(0);
$table->boolean('show_in_nav')->nullable()->default(0);
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class AddDefaultFlagOnStatuslabels extends Migration
public function up()
{
Schema::table('status_labels', function (Blueprint $table) {
$table->boolean('default_label')->default(0);
$table->boolean('default_label')->nullable()->default(0);
});
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;
use App\Models\Statuslabel;

class ChangeDefaultLabelToNullable extends Migration
{
/**
* Run the migrations.
*
* This is stupid because it has a default valuye of 0 so it *should*
* default to 0, but it doesn't on some versions of MySQL.
*
* @return void
*/
public function up()
{


Statuslabel::whereNull('default_label')
->update(['default_label' => 0]);

Statuslabel::whereNull('show_in_nav')
->update(['show_in_nav' => 0]);


Schema::table('status_labels', function (Blueprint $table) {
$table->boolean('default_label')->nullable()->default(0)->change();
$table->boolean('show_in_nav')->nullable()->default(0)->change();
});


}

/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
//
}
}