Location validation does not prevent circular references with parent

[travismiller]

Please confirm you have done the following before posting your bug report:

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug
It is possible to create a circular reference of locations.

To Reproduce
Steps to reproduce the behavior:

• Create a location A
• Create a location B with parent A
• Edit Location A with parent B

The save will proceed without error, but locations will no longer load after that.

Expected behavior
Validation should prevent this situation.

Server (please complete the following information):

• Snipe-IT Version v4.9.3
• OS: Ubuntu/Docker
• Web Server: Ubuntu/Docker/Apache
• PHP Version 7.1.33-16+ubuntu16.04.1+deb.sury.org+1

Error Messages

HTTP Response from http://localhost:3051/api/v1/locations?order=asc&offset=0&limit=20

< HTTP/1.0 500 Internal Server Error
< Date: Wed, 22 Jul 2020 14:36:49 GMT
< Server: Apache/2.4.18 (Ubuntu)
< Content-Length: 0
< Connection: close
< Content-Type: text/html; charset=UTF-8

/var/log/apache2/error.log

[Wed Jul 22 14:34:02.587257 2020] [php7:error] [pid 1883] [client 172.25.0.1:33390] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 32768 bytes) in /var/www/html/vendor/symfony/debug/Exception/FatalErrorException.php on line 1, referer: http://localhost:3051/locations

[stale]

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

[stale]

This issue has been automatically closed because it has not had recent activity. If you believe this is still an issue, please confirm that this issue is still happening in the most recent version of Snipe-IT and reply to this thread to re-open it.