Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation #151

Closed
votsdb opened this issue Jun 8, 2014 · 10 comments
Closed

Translation #151

votsdb opened this issue Jun 8, 2014 · 10 comments

Comments

@votsdb
Copy link

votsdb commented Jun 8, 2014

Has anyone do a complete system translated into your own language? I translated the en folder into my own language, but still some which is not translated, please advise, thank you very much.

@snipe
Copy link
Owner

snipe commented Jun 9, 2014

Hi @votsdb - if you can let me know what strings we've missed, I'm happy to add those to the language files.

@votsdb
Copy link
Author

votsdb commented Jun 9, 2014

I already translated in the code, and it's about 95% translated now. that will work for me at the meantime, but if you have a complete translation that would be nicer. Thank you very much for your hard work Snipe. by the way I like your hair if that avatar is you.

@snipe
Copy link
Owner

snipe commented Jun 9, 2014

I don't think you're understanding my question. The way translations work is that I have to substitute English words for language placeholder strings, which are then translated in the lang folder. My point is that since I speak English, it's difficult for me to see what hasn't been abstracted out into strings, since it's English either way as I look at it. If you've translated the lang directory to create a vietnamese translation (which is great if you did - please consider submitting a pull request to submit your translation to the Snipe IT library), if you can tell me what is still showing up in English, I can locate the rest of the English strings that are hard-coded, and move them into the lang setup.

@votsdb
Copy link
Author

votsdb commented Jun 9, 2014

I translated the en folder into Vietnamese, and it some of them still in English, then I went to the app/views and translate them all. then the whole system was translated into Vietnamese. so I guess you're missing the string in the app/views folder.

@snipe
Copy link
Owner

snipe commented Jun 9, 2014

Yes, that's the question I'm asking you - which strings you translated directly into the views. (It would have been better if you had pulled them into language strings, so everyone could benefit from your work, but that's fine.)

@votsdb
Copy link
Author

votsdb commented Jun 9, 2014

sorry I didn't create a new folder for vietnamese, I just translated the en folder, I shoulda create a vi folder and copy the en over then do the translation, but at first I thought well, I am using it only in one language, that's why I just left it like that and do the translation. after translated the en folder into Vietnamese, I noticed that there was some still in English, then I went to app/views and translate those English text in those files, then I got my system is now fully translated.

@snipe
Copy link
Owner

snipe commented Jun 9, 2014

Only using it for one language is okay, but next time please consider creating the vi directory and submitting your Vietnamese translation. It's a nice way to give back to the project so that other people can benefit.

I understand what you did - what I'm asking is which strings you had to manually translate in the views directory, so that I can find them and make them multi-lingual.

Never mind. I'll figure it out myself.

@votsdb
Copy link
Author

votsdb commented Jun 9, 2014

sure I will do that for the next version. Thank you Snipe.

@snipe
Copy link
Owner

snipe commented Jun 9, 2014

Great, thanks!

snipe added a commit that referenced this issue Jun 9, 2014
snipe added a commit that referenced this issue Jun 9, 2014
snipe added a commit that referenced this issue Jun 9, 2014
@snipe snipe self-assigned this Jun 9, 2014
snipe added a commit that referenced this issue Jun 9, 2014
snipe added a commit that referenced this issue Jun 9, 2014
snipe added a commit that referenced this issue Jun 10, 2014
snipe added a commit that referenced this issue Jun 17, 2014
snipe added a commit that referenced this issue Jul 8, 2014
@snipe snipe closed this as completed in dc10330 Jul 19, 2014
@snipe
Copy link
Owner

snipe commented Jul 19, 2014

I think I've gotten most of the translation strings now. If you see any additional that are missing, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants