Can't install Snipe-it 5.3.8 in sub-directory

[GaneshKandu]

Snipe-IT Version

5.3.8

Operating System

Linux CentOS

Web Server

Apache

PHP Version

PHP 7.4.25

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Hi,

I am trying to install Snipe-it 5.3.8 in sub-directory Ex. http://mydomain.com/subdirectory/snipeit/public
but Snipe-it looking css, js and images in root http://mydomain.com but they are present at http://mydomain.com/subdirectory/snipeit/public therefore it causing 404 error

Describe the solution you'd like A clear and concise description of what you want to happen.

you can set other files and folder as data directory except public any where in non accessible directory
and public for any where in web accessible

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

No response

Additional context Add any other context or screenshots about the feature request here.

No response

[GaneshKandu]

@uberbrady you able to reproduce this bug ?

[chrisgraf]

Same here after an Update via php upgrade.php. It used to work before (I don't know the exact version)

[snipe]

Can you both tell me what you have set as your APP_URL in your .env?

[chrisgraf]

It's APP_URL=https://<domainname>/snipeit for me

[GaneshKandu]

APP_URL=http://mydomain.com/subdirectory/snipeit/public

[uberbrady]

public should not be in there.

[GaneshKandu]

Still not working

[snipe]

Thanks for the feedback. We've made it abundantly clear that Snipe-IT does not want to be run in a subdirectory. We're working on fixing the issue here, but at the end of the day, the better answer is: Just Don't If You Can Avoid It.

We'll update this GH issue with our progress - please hang tight.

[chrisgraf]

I know, but as it worked until now I didn't expect this to break. For us running it on a subdomain is not an option. Thanks a lot for your effort! Is there an easy way to downgrade again in the meantime?

[snipe]

We made some changes to how root urls work in order to handle a laravel-level security issue. Brady has been assigned to this issue and I’m confident he’ll get it sorted.

[savornicesei]

I can confirm the issue. As a workaround (since I'm running Snipe-IT in a Bitnami LAMPP env. limited to localhost) I've set
APP_ALLOW_INSECURE_HOSTS=true in .env file, based on the changes made in this commit.

Thanks.

[uberbrady]

Excellent workaround, @savornicesei - yes, that will at least disable the code that I added until I can get it all sorted out. I can’t believe that I didn’t think of mentioning it earlier, thank you!

It’s tough for me to work on because I don’t have a good test environment for subdirectories right now so I’m kinda struggling.

The test I want to see (with APP_ALLOW_INSECURE_HOSTS unset, of course), is this:

Changing this line:

snipe-it/app/Providers/AppServiceProvider.php

Line 52 in db0a078

\URL::forceRootUrl($root_url);

To instead say something like:

\URL::forceRootUrl(config(‘app.url’));

I’m wondering if that makes it work any better?

[savornicesei]

@uberbrady With \URL::forceRootUrl(config('app.url')); and APP_ALLOW_INSECURE_HOSTS=false Snipe-It configured as a subdirectory works fine.

[uberbrady]

I'll try and get a PR up with this today. Thanks for the troubleshooting help, @savornicesei !

[savornicesei]

@uberbrady No problem. Glad to help! Let me know if and when you need additional subdirectory testing :)