-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move include to allow library re-use #66
Comments
+1 for the pull request ;) |
Move tf include from header to cpp files, fixes #66
Hi Scott. Could you release 0.5.2 to jade so we have the fix there as well? It's still 0.5.1 and causing problems for us. Thanks! |
Due to time constraints, I don’t handle the releases (or maintenance) anymore - there are a few maintainers I’ve asked to help out. Would someone be willing to do this? Isaac maybe? —Scott
|
Sure. |
Thanks!
|
Done |
We would like to be able to re-use the alvar library in other nodes or software. In particular, we strive to use it as a fallback on Ubuntu for the RoboCup Logistics League Simulation. However, this is currently prevented because the file Camera.h contains the following:
include <tf/transform_broadcaster.h>
This pulls in a lot of the tf2 infrastructure. This in turn is currently incompatible on our side. The include is actually not used in the library defined by the headers. Rather the only reference is within the nodes. Therefore, if the line was moved out of the header and into the individual nodes, we could use the alvar library and the nodes would work without any difference.
It would be great if this were accepted and could be released as an indigo update. I can provide a patch if desired.
The text was updated successfully, but these errors were encountered: